Glasgow | 26-ITP-May | Lavanya Jayaprabu | Sprint 2 | Wireframe#1350
Open
Lavanya-Projects wants to merge 11 commits into
Open
Glasgow | 26-ITP-May | Lavanya Jayaprabu | Sprint 2 | Wireframe#1350Lavanya-Projects wants to merge 11 commits into
Lavanya-Projects wants to merge 11 commits into
Conversation
I changed the title a bit
This reverts commit 136970a.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lavanya-Projects
added
📅 Sprint 2
Lavanya-Projects
added
Needs Review
WeiTsungCheng
added
Review in progress
| </main> | ||
| <footer> | ||
| <p> | ||
| © 2026 Wireframe Web Page. Contact • CodeYourFuture • All Rights Reseved. |
WeiTsungCheng
left a comment
WeiTsungCheng
left a comment
There was a problem hiding this comment.
Overall, you’ve done a great job. One suggestion would be to keep the headings and content areas aligned at the same height across the cards, and make the buttons the same size. This would create a more balanced and polished appearance.
WeiTsungCheng
added
Reviewed
Author
|
Thank you @ WeiTsungCheng for the feedback, I added some commits based on the feedback. |
Lavanya-Projects
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have changed the title and description for the wireframe based on the requirements.
Added appropriate images on the placeholder section
Changed the article names and description
Made some changes in CSS to match the reference wireframe image
Used "class" attribute to style the particular element
Questions
As a beginner its quite difficult to understand the wireframe CSS, like you mentioned ":root" and using variable on it. This is the first time I am using these things...